Microsoft.Build: netstandard2.0 instead of netcoreapp2.0 #3126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's harder for projects to depend on us if we're netcoreapp2.0, because they must themselves be .NET Core specific rather than netstandard. We only need to be netcoreapp2.1, though--in 2.0 mode we can be netstandard.
AndyGerlicher
approved these changes
Mar 23, 2018
Member
Author
|
@dotnet-bot test Windows_NT Build for CoreCLR please |
cdmihai
reviewed
Mar 23, 2018
| <TargetFrameworks>$(RuntimeOutputTargetFrameworks)</TargetFrameworks> | ||
| <!-- Node reuse requires an API new to .NET Core 2.1 not yet available | ||
| in .NETStandard. --> | ||
| <TargetFrameworks>netstandard2.0;netcoreapp2.1</TargetFrameworks> |
Contributor
There was a problem hiding this comment.
How does this not break our netcoreapp2.0 target? I assume that one's also getting tested, right?
Member
Author
There was a problem hiding this comment.
The netcoreapp2.0 target uses the netstandard2.0 library from here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's harder for projects to depend on us if we're netcoreapp2.0, because
they must themselves be .NET Core specific rather than netstandard.
We only need to be netcoreapp2.1, though--in 2.0 mode we can be
netstandard.